Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Forcenew instance fields #5025

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

ismirlia
Copy link
Collaborator

@ismirlia ismirlia commented Jan 5, 2024

This pull request in response to: #4901

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

ismirlia and others added 4 commits December 11, 2023 16:56
The image id you pass in does not match the image id of the instance
created, so if you apply twice in row terraform thinks it has to
remake the instance when that's not true.
@ismirlia ismirlia changed the title Forcenew instance fields Update Forcenew instance fields Jan 5, 2024
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yussufsh yussufsh added the service/Power Systems Issues related to Power Systems label Jan 8, 2024
@yussufsh
Copy link
Collaborator

yussufsh commented Jan 8, 2024

@ismirlia acceptance tests will be helpful here.

@ismirlia
Copy link
Collaborator Author

ismirlia commented Jan 8, 2024

@yussufsh

Here are some of the acceptance tests I managed to run:

--- PASS: TestAccIBMPIInstanceBasic (601.80s)
PASS
--- PASS: TestAccIBMPIInstanceUserData (417.32s)
PASS

Unfortunately due to some resource shortages or configuration issues I was not able to run more of them.

@hkantare hkantare merged commit 39adf82 into IBM-Cloud:master Feb 5, 2024
1 check passed
@michaelkad michaelkad deleted the forcenew-instance-fields branch May 28, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants