File share Mount target resource rename #4604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hkantare
reviewed
Jun 9, 2023
| return diag.FromErr(err) | ||
| } | ||
|
|
||
| d.SetId(fmt.Sprintf("%s/%s", *createShareMountTargetOptions.ShareID, *shareTarget.ID)) |
There was a problem hiding this comment.
Can we setID before waitingfor available. If soemtimes waiting intermittely the state file will hold ID and helps in future run
There was a problem hiding this comment.
moved above wait logic call
| log.Printf("[DEBUG] GetShareMountTargetWithContext failed %s\n%s", err, response) | ||
| return diag.FromErr(err) | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we check shareTarget != nil and then access *shareTarget.X for eliminating nil pointer exception .
or Add in above
if err != nil || shareTarget = nil{
There was a problem hiding this comment.
added shareTarget == nil check
|
adding a fix. moving to draft till then |
|
Fix added and tested. PR is ready to review and merge |
omaraibrahim
pushed a commit
to omaraibrahim/terraform-provider-ibm
that referenced
this pull request
Jul 20, 2023
* Deprecated share target and added share mount target resources and data sources * added maturity * updated beta sdk version and removed custom sdk * updated read methods * pr review comments fix * fix for concurrent target create and delete issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated ibm_is_share_target resource and datasources
Added ibm_is_share_mount_target