Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Cloud Databases): use correct redis maxmemory configuration #4588

Merged
merged 1 commit into from
May 31, 2023
Merged

fix(Cloud Databases): use correct redis maxmemory configuration #4588

merged 1 commit into from
May 31, 2023

Conversation

alexhemard
Copy link
Collaborator

Update cloud-databases-go-sdk , which uses the correct redis maxmemory configuration parameter

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes: #4528

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIBMDatabaseInstance_Redis'
--- PASS: TestAccIBMDatabaseInstance_Redis_Basic (721.74s)

...

omaraibrahim
omaraibrahim approved these changes May 26, 2023
View reviewed changes
Copy link
Collaborator

@omaraibrahim omaraibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

@hkantare hkantare merged commit 708bbbe into IBM-Cloud:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omaraibrahim omaraibrahim omaraibrahim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Redis] Regression > 1.50.0 on maxmemory / maxmerory-redis configuration parameter
3 participants
@alexhemard @omaraibrahim @hkantare