Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Private DNS support for load balancers #4463

Merged
merged 22 commits into from
Apr 14, 2023
Merged

Feature: Private DNS support for load balancers #4463

merged 22 commits into from
Apr 14, 2023

Conversation

deepaksibm
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@deepaksibm
Copy link
Contributor Author 


tfpt TestAccIBMISLBDatasource_pDNS
=== RUN   TestAccIBMISLBDatasource_pDNS
--- PASS: TestAccIBMISLBDatasource_pDNS (556.45s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     557.427s

tfpt TestAccIBMISLB_DNS
=== RUN   TestAccIBMISLB_DNS
--- PASS: TestAccIBMISLB_DNS (775.09s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     776.617s

@deepaksibm
Copy link
Contributor Author 

$ tfpt TestAccIBMISLB_basic_udp

=== RUN   TestAccIBMISLB_basic_udp
--- PASS: TestAccIBMISLB_basic_udp (843.14s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     844.148s

@hkantare
Copy link
Collaborator

Fix the conflicts

@deepaksibm
Copy link
Contributor Author

Fix the conflicts

resolved conflicts

@hkantare hkantare merged commit 0226574 into IBM-Cloud:master Apr 14, 2023
omaraibrahim pushed a commit to omaraibrahim/terraform-provider-ibm that referenced this pull request Jul 20, 2023
@deepaksibm @omaraibrahim
Feature: Private DNS support for load balancers (IBM-Cloud#4463)
bc1a10c 
* sdk changes

* support for vpc load balancer private dns

* load balancer private dns create

* lb dns patch

* lb dns get

* datasource and doc changes

* instance_crn and doc update

* zone id changing

* added min items

* test case improvement

* doc improvement

* test and doc improvement

* make fmt changes

* dns name removal changes

* sdk update

* sdk migration changes in TFP

* sdk update and migration

* doc example and test enhancement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepaksibm @hkantare