call WorkerPoolUpdate at the end of create #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewiseevans
approved these changes
Mar 1, 2023
hkantare
reviewed
Mar 2, 2023
| @@ -275,7 +275,7 @@ func resourceIBMContainerWorkerPoolCreate(d *schema.ResourceData, meta interface | |||
|
|
|||
| d.SetId(fmt.Sprintf("%s/%s", clusterNameorID, res.ID)) | |||
|
|
|||
| return resourceIBMContainerWorkerPoolRead(d, meta) | |||
| return resourceIBMContainerWorkerPoolUpdate(d, meta) | |||
| } | |||
There was a problem hiding this comment.
In update method resourceIBMContainerWorkerPoolUpdate we do have other two d.HasChange("size_per_zone") and d.HasChange("labels") will also diff even if we used them during of create worker pool . Can you add this condition also
if d.HasChange("size_per_zone") && !d.IsNewResource()
for both else it will unneceessaty update calls.
There was a problem hiding this comment.
makes sense, thx. added the check in a241014
IBM-diksha
pushed a commit
to IBM-diksha/terraform-provider-ibm
that referenced
this pull request
Mar 17, 2023
* call WorkerPoolUpdate at the end of create * check for new resource in WorkerPoolUpdate --------- Co-authored-by: Zoltan Illes <zoltan.illes@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing: