Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Cloud Databases): Allow users to edit configuration on database creation #4186

Merged
merged 4 commits into from
Nov 18, 2022

Conversation

omaraibrahim
Copy link
Collaborator

Users cannot edit their database configuration on database creation. This PR allows users to do so.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TEST=./ibm/service/database TESTARGS='-run=TestAccIBMDatabaseInstancePostgresBasic'
--- PASS: TestAccIBMDatabaseInstancePostgresBasic
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database
$  make testacc TEST=./ibm/service/database TESTARGS='-run=TestAccIBMDatabaseInstanceMongodbBasic'
--- PASS: TestAccIBMDatabaseInstanceMongodbBasic (1138.88s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database        1139.922s
make testacc TEST=./ibm/service/database TESTARGS='-run=TestAccIBMDatabaseInstance_Redis_Basic'
--- PASS: TestAccIBMDatabaseInstance_Redis_Basic (790.05s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database        791.109s

@obai-1 obai-1 merged commit c7a5da5 into IBM-Cloud:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants