Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIS Firewall Rules : added pause key in create #4142

Merged
merged 1 commit into from
Nov 8, 2022
Merged

CIS Firewall Rules : added pause key in create #4142

merged 1 commit into from
Nov 8, 2022

Conversation

arpit-srivastava-ibm
Copy link
Contributor

Problem Statement -

  • User was not able to update pause field in Firewall Rules while creating a resource. It worked perfectly fine while updating.

Issue - https://github.ibm.com/NetworkTribe/CIS_Support/issues/2718

@arpit-srivastava-ibm
Copy link
Contributor Author

arpit-srivastava-ibm commented Nov 7, 2022 •
edited
Loading

Added Test case -

arpit-mac@Arpits-MacBook-Pro terraform-provider-ibm % make testacc TEST=./ibm/service/cis TESTARGS='-run=TestAccIBMCisFirewallrules_Basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/cis -v -run=TestAccIBMCisFirewallrules_Basic -timeout 700m
=== RUN   TestAccIBMCisFirewallrules_Basic
--- PASS: TestAccIBMCisFirewallrules_Basic (88.49s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cis	89.694s

@hkantare hkantare merged commit 97a725c into IBM-Cloud:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arpit-srivastava-ibm @hkantare