Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attach script loop for satellite host attach #4117

Merged
merged 8 commits into from
Oct 26, 2022
Merged

Fix attach script loop for satellite host attach #4117

merged 8 commits into from
Oct 26, 2022

Conversation

bhpratt
Copy link
Contributor

@bhpratt bhpratt commented Oct 18, 2022

Custom code is overwriting part of the attach script in some locations, causing the attach script to fail.

This update provides a change to insert the custom code rather than overwriting a line in the attach script. In addition, it changes else/if loop to case for easier code readability and maintenance.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

 make testacc TEST=./ibm/service/satellite TESTARGS='-run=TestAccIBMSatelliteAttachHostScriptDataSourceBasic'
=== RUN   TestAccIBMSatelliteAttachHostScriptDataSourceBasic
--- PASS: TestAccIBMSatelliteAttachHostScriptDataSourceBasic (886.52s)
=== RUN   TestAccIBMSatelliteAttachHostScriptDataSourceBasicCoreos
--- PASS: TestAccIBMSatelliteAttachHostScriptDataSourceBasicCoreos (1172.36s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/satellite	2060.180s

@bhpratt bhpratt marked this pull request as ready for review October 19, 2022 20:17
@hkantare hkantare merged commit a5139fb into IBM-Cloud:master Oct 26, 2022
@bhpratt bhpratt deleted the fix-attach-script-loop branch October 26, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants