Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Description for Deployment type EPIC #4037

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Updated Description for Deployment type EPIC #4037

merged 2 commits into from
Sep 15, 2022

Conversation

bhagyagkwd
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

rmoralesjr
rmoralesjr requested changes Sep 14, 2022
View reviewed changes
Copy link
Collaborator

@rmoralesjr rmoralesjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change for the data source docs. Thanks

website/docs/d/pi_instance.html.markdown Outdated Show resolved Hide resolved
rmoralesjr
rmoralesjr approved these changes Sep 14, 2022
View reviewed changes
Copy link
Collaborator

@rmoralesjr rmoralesjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks

@hkantare hkantare merged commit 1507486 into IBM-Cloud:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoralesjr rmoralesjr rmoralesjr approved these changes

@hkantare hkantare Awaiting requested review from hkantare

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhagyagkwd @rmoralesjr @hkantare