Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rhel8 in attach script #4033

Merged
merged 7 commits into from
Oct 17, 2022
Merged

Conversation

crhuff-ibm
Copy link
Contributor

@crhuff-ibm crhuff-ibm commented Sep 13, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #3987

Output from acceptance testing:

$ make testacc TEST=./ibm/service/satellite TESTARGS='-run=TestAccIBMSatelliteAttachHostScriptDataSourceBasic'
=== RUN   TestAccIBMSatelliteAttachHostScriptDataSourceBasic
--- PASS: TestAccIBMSatelliteAttachHostScriptDataSourceBasic (1259.67s)
=== RUN   TestAccIBMSatelliteAttachHostScriptDataSourceBasicCoreos
--- PASS: TestAccIBMSatelliteAttachHostScriptDataSourceBasicCoreos (1179.38s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/satellite       2439.918s

@crhuff-ibm crhuff-ibm marked this pull request as ready for review September 14, 2022 17:08
@crhuff-ibm crhuff-ibm marked this pull request as draft September 22, 2022 13:28
@crhuff-ibm crhuff-ibm marked this pull request as ready for review October 10, 2022 15:05
@crhuff-ibm
Copy link
Contributor Author

This PR is based on what the bootstrap team does to spin up and test rhel 8 clusters, and makes what we put on our host script in line with that. It also removes unnecessary/overly broad package allowances.

@crhuff-ibm crhuff-ibm changed the title Support rhel8 in attach script and run fmt Support rhel8 in attach script Oct 11, 2022
@hkantare hkantare merged commit f8b2bb0 into IBM-Cloud:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants