Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreos host attach support #3968

Merged
merged 1 commit into from
Aug 17, 2022
Merged

coreos host attach support #3968

merged 1 commit into from
Aug 17, 2022

Conversation

bhpratt
Copy link
Contributor

@bhpratt bhpratt commented Aug 11, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #3838

Output from acceptance testing:

=== RUN   TestAccIBMSatelliteAttachHostScriptDataSourceBasic
--- PASS: TestAccIBMSatelliteAttachHostScriptDataSourceBasic (799.33s)
=== RUN   TestAccIBMSatelliteAttachHostScriptDataSourceBasicCoreos
--- PASS: TestAccIBMSatelliteAttachHostScriptDataSourceBasicCoreos (1154.23s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/satellite       1955.980s

@bhpratt
Copy link
Contributor Author

bhpratt commented Aug 11, 2022

adding outputs from tests run.

addHost-no-coreos_host-flag.txt - this is from test #1 (no flag)
addHost-coreos_host.txt - this is from test #2 - flag + coreos location

addHost-no-coreos_host-flag.txt
addHost-coreos_host.txt

@bhpratt
Copy link
Contributor Author

bhpratt commented Aug 11, 2022

@kavya498 new PR due to squash commit issues w/the original #3952

Regarding this comment: Can we use d.GetOkExists("coreos_host") instead of d.GetOk("coreos_host")

I can change that, but I see this comment:

// GetOkExists can check if TypeBool attributes that are Optional with
// no Default value have been set.
//
// Deprecated: usage is discouraged due to undefined behaviors and may be
// removed in a future version of the SDK

Should I still use it despite the deprecation notice?

@bhpratt
Copy link
Contributor Author

bhpratt commented Aug 11, 2022

I will work on building the provider locally and testing. But I've included the output of the attach host scripts from the respective tests.

@bhpratt bhpratt marked this pull request as ready for review August 15, 2022 17:04
@bhpratt
Copy link
Contributor Author

bhpratt commented Aug 15, 2022

@kavya498 Okay, I've completed testing locally. Uploading results from plan/applies
test.txt

In addition - I did more testing w/the local build. I created both CoreOS-enabled and non-CoreOS-enabled locations with no coreos_host flag in the data source. Generated addHost.sh as expected.

I then added the flag and re-applied and both succeeded. If I switched the flag to coreos_host = true on the CoreOS-enabled location, I got addHost.ign as expected.

@hkantare hkantare merged commit e5cb049 into IBM-Cloud:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable coreos support for IBM Cloud Satellite location creation
2 participants