Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Over Count Bug Fix #3946

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Conversation

SunithaGudisagarIBM
Copy link
Collaborator

@SunithaGudisagarIBM SunithaGudisagarIBM commented Aug 3, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000
delete_over_count cannot be 0, is allowed to set to null`.

Output testing:

resource "ibm_is_backup_policy" "is_backup_policy" {
  match_user_tags = ["tag-0"]
  name            = "backup-policy"
}

resource "ibm_is_backup_policy_plan" "is_backup_policy_plan_import" {
  backup_policy_id = ibm_is_backup_policy.is_backup_policy.id
  name             = "backup-policy-plan"
  cron_spec        = "40 2 * * *"
  deletion_trigger {
    delete_over_count = "50"
  }
}

Screenshot 2022-08-03 at 5 21 17 PM

@SunithaGudisagarIBM
Copy link
Collaborator Author

SunithaGudisagarIBM commented Aug 12, 2022

@hkantare we have internally reviewed ibm-vpc#165 PR and provided the go to this PR,
Can you please review and merge this PR.
Thank you very much
Sunitha

@hkantare hkantare merged commit cc54999 into IBM-Cloud:master Aug 17, 2022
@SunithaGudisagarIBM SunithaGudisagarIBM deleted the bugfix-is-baas branch September 15, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants