Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CoreOS-enabled option for Satellite location create #3914

Merged
merged 10 commits into from
Jul 20, 2022
Merged

Add CoreOS-enabled option for Satellite location create #3914

merged 10 commits into from
Jul 20, 2022

Conversation

bhpratt
Copy link
Contributor

@bhpratt bhpratt commented Jul 6, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #3838

Output from acceptance testing:

Running tool: /usr/local/go/bin/go test -timeout 30s -run ^TestAccSatelliteLocation_Basic$ github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/satellite

ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/satellite	0.892s

make testacc TEST=./ibm/service/satellite TESTARGS='-run=TestAccSatelliteLocation_Basic'                
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/satellite -v -run=TestAccSatelliteLocation_Basic -timeout 700m

....

[INFO] Set the environment variable IBM_CLUSTER_ID for ibm_container_vpc_worker_pool resource or datasource else tests will fail if this is not set correctly
=== RUN   TestAccSatelliteLocation_Basic
--- PASS: TestAccSatelliteLocation_Basic (1108.65s)
PASS

Note, does require updating container services SDK to latest: github.com/IBM-Cloud/container-services-go-sdk v0.0.0-20220622142911-811d18c8c775 to pick up SDK updates.

Related SDK PRs:

IBM-Cloud/container-services-go-sdk#4 (comment)
https://github.com/IBM-Cloud/container-services-go-sdk/pull/5/files

@bhpratt
Copy link
Contributor Author

bhpratt commented Jul 7, 2022

Let me know how you'd like to handle the test - I updated it to check if coreos_enabled is true. However, I can revert or create a new test case that tests coreos separately.

@hkantare hkantare merged commit 86db90f into IBM-Cloud:master Jul 20, 2022
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
* initial changes to accept coreos locations

* fixed reference to variable

* added doc for new variable

* update to use the latest version of satellite SDK

* updated test to check for coreosenabled

* added computed field and added to Read

* add coreos enabled arguments to data source

* remove optional as data source is only computed

* add core_enabled attribute to data source docs

Co-authored-by: bhpratt <bhpratt@ncsu.edu>
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
* initial changes to accept coreos locations

* fixed reference to variable

* added doc for new variable

* update to use the latest version of satellite SDK

* updated test to check for coreosenabled

* added computed field and added to Read

* add coreos enabled arguments to data source

* remove optional as data source is only computed

* add core_enabled attribute to data source docs

Co-authored-by: bhpratt <bhpratt@ncsu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants