added docs & enhanced network-port-attach resource #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkantare
reviewed
May 16, 2022
| }, | ||
| Schema: map[string]*schema.Schema{ | ||
| "port_id": { | ||
| Type: schema.TypeString, |
There was a problem hiding this comment.
The required argument can't be removed directly needs to follow Terraform guidelines
https://www.terraform.io/plugin/sdkv2/best-practices/deprecations
There was a problem hiding this comment.
Is this resources we are exposin to the users for the first time ?
There was a problem hiding this comment.
this resource was present in an earlier version but without documentation, the network-port resource will be deprecated and the features of network-port will combine in the network-port-attach resource
| }, | ||
| helpers.PIInstanceName: { | ||
| helpers.PIInstanceId: { |
There was a problem hiding this comment.
Same as above can't change a argument ..
SunithaGudisagarIBM
pushed a commit
to ibm-vpc/terraform-provider-ibm
that referenced
this pull request
Sep 14, 2022
* add/update network port attach resource * feedback resolved * improved network port attach docs
SunithaGudisagarIBM
pushed a commit
to ibm-vpc/terraform-provider-ibm
that referenced
this pull request
Sep 14, 2022
* add/update network port attach resource * feedback resolved * improved network port attach docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing: