Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for optional weight attribute's value #3684

Merged
merged 5 commits into from
May 16, 2022

Conversation

BShrivastav
Copy link
Contributor

Fix for optional weight attr set to 0 when not provided.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #UI-21513
https://jiracloud.swg.usma.ibm.com:8443/browse/UI-21513
Output from acceptance testing:

$ make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISLBPoolMember_basic_opt_weight_check'
=== RUN   TestAccIBMISLBPoolMember_basic_opt_weight_check
--- PASS: TestAccIBMISLBPoolMember_basic_opt_weight_check (807.13s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc	808.130s

...

Fix for optional weight attr set to 0 when not provided.
@@ -63,7 +63,7 @@ Review the argument references that you can specify for your resource.
- `port`- (Required, Integer) The port number of the application running in the server member.
- `target_address` - (Required, String) The IP address of the pool member.
- `target_id` - (Required, String) The unique identifier for the virtual server instance pool member. Required for network load balancer.
- `weight` - (Optional, Integer) Weight of the server member. This option takes effect only when the load-balancing algorithm of its belonging pool is `weighted_round_robin`, Minimum allowed weight is `0` and Maximum allowed weight is `100`.
- `weight` - (Optional, Integer) Weight of the server member. This option takes effect only when the load-balancing algorithm of its belonging pool is `weighted_round_robin`, Minimum allowed weight is `0` and Maximum allowed weight is `100`. When weight is not provided a default of 40 is returned.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in test case you said default is 50 but in docs its 40 can you confirm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified with right info.

@hkantare hkantare merged commit 0d8ebd9 into IBM-Cloud:master May 16, 2022
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
* Fix for optional weight attribute's value

Fix for optional weight attr set to 0 when not provided.

* ssh key removal

* weight default info added in docs

weight default info added in docs.

* upd docs

upd docs
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
* Fix for optional weight attribute's value

Fix for optional weight attr set to 0 when not provided.

* ssh key removal

* weight default info added in docs

weight default info added in docs.

* upd docs

upd docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants