Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate key policies from Key Resource #3670

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

harshit777
Copy link
Contributor

No description provided.

@harshit777
Copy link
Contributor Author

Tested the code with respect to provisioning with old binary and new binary, no diff can be seen.

@harshit777
Copy link
Contributor Author

#3047 : we can close this PR since its very old and there has been code restructuring to so path to this PR is not available.

Copy link

@dinesh-venkatraman-g dinesh-venkatraman-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@dinesh-venkatraman-g dinesh-venkatraman-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshit777 can you add test evidences?

@harshit777
Copy link
Contributor Author

Old Binary
Screenshot 2022-03-21 at 11 14 56 AM
Screenshot 2022-03-21 at 11 12 02 AM

Terraform plan with New Binary

Screenshot 2022-03-21 at 11 58 26 AM

Screenshot 2022-03-21 at 12 00 29 PM

@hkantare hkantare merged commit 5dd5b25 into IBM-Cloud:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants