Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic network type address #3659

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Support dynamic network type address #3659

merged 1 commit into from
Mar 23, 2022

Conversation

yussufsh
Copy link
Collaborator

  1. Removed deprecated attributes:
  • Addresses->Networks
  • IP->IPAddress
  1. Additional check for dynamic network address where IPAddress is " ".

Signed-off-by: Yussuf Shaikh yussuf.shaikh@ibm.com

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMPIInstanceIPDataSource_basic
--- PASS: TestAccIBMPIInstanceIPDataSource_basic (82.78s)
PASS


Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
@yussufsh yussufsh added the service/Power Systems Issues related to Power Systems label Mar 14, 2022
@yussufsh yussufsh requested a review from hkantare March 14, 2022 14:15
@yussufsh
Copy link
Collaborator Author

@hkantare please help with review. Need this in the next release.

@hkantare hkantare merged commit bb6e6fe into IBM-Cloud:master Mar 23, 2022
@yussufsh yussufsh deleted the s branch March 29, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants