Add code to allow SAP create with a placement group #3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yussufsh
reviewed
Mar 7, 2022
ChaseRun
approved these changes
Mar 7, 2022
Add code to allow SAP create with a placement group and include document statements with the restrictions that apply with placement groups on instance deployment
rmoralesjr
force-pushed
the
SAPCreatePlacementGroup
branch
from
9f3e8cc
to
dad927f
Compare
hkantare
reviewed
Mar 14, 2022
| Type: schema.TypeString, | ||
| Required: true, | ||
| Description: "PI instance image id", | ||
| DiffSuppressFunc: flex.ApplyOnce, |
There was a problem hiding this comment.
Why is the diff suprress func applied ?
There was a problem hiding this comment.
@hkantare when using a stock image the result image id from the pvm instance depends on the storage controller used to deploy the image. Here user provided configuration is not always same as the instance image id. Terraform would always show a diff to be applied which was also failing the test cases at some places depending on the storage controller selected automatically by the service provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add code to allow SAP create with a placement group
and include document statements with the restrictions
that apply with placement groups on instance deployment
Community Note
Relates OR Closes #0000
Output from acceptance testing:
=== RUN TestAccIBMPIPlacementGroupBasic
--- PASS: TestAccIBMPIPlacementGroupBasic (2150.42s)
PASS