Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new resource attribute service_type for access policies #3347

Merged
merged 3 commits into from
Dec 1, 2021
Merged

Added new resource attribute service_type for access policies #3347

merged 3 commits into from
Dec 1, 2021

Conversation

Rajesh-Pirati
Copy link
Contributor

@Rajesh-Pirati Rajesh-Pirati commented Nov 19, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #3192

Output from acceptance testing:

image

image

image

image

image
image

image

@Rajesh-Pirati Rajesh-Pirati marked this pull request as ready for review November 22, 2021 08:16
swcolley
swcolley reviewed Nov 22, 2021
View reviewed changes
website/docs/r/iam_service_policy.html.markdown Outdated
roles = ["Viewer"]

resources {
service_type = "service"
Copy link
Contributor

@swcolley swcolley Nov 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this line be formatted the same as other md files?
It looks like it's indented to far to the right.

swcolley
swcolley suggested changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@swcolley swcolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terraform Changes and tests look good. I left one comment about a md file.

swcolley
swcolley approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@swcolley swcolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@hkantare hkantare merged commit 09644cb into IBM-Cloud:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare approved these changes

@kavya498 kavya498 kavya498 approved these changes

@swcolley swcolley swcolley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Access policies with resource attributes update on subsequent terraform execution
4 participants
@Rajesh-Pirati @hkantare @kavya498 @swcolley