Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore label to enable node-local-dns-enabled for kubernetes service #3232

Merged
merged 2 commits into from
Oct 21, 2021

Conversation

Nashluffy
Copy link
Contributor

@Nashluffy Nashluffy commented Oct 19, 2021

To enable node local dns caching, IKS requires you to put the label ibm-cloud.kubernetes.io/node-local-dns-enabled:true on worker pools. In terraform, the resource_ibm_container_vpc_worker_pool calls IgnoreSystemLabels which excludes anything with ibm-cloud prefix. I understand the general requirement to ignore IBM labels that IKS appends, but this prefix should not be skipped.

Right now, every time I run terraform plan it shows that it will add this label, even though it already exists.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

…ervice

To enable node local dns caching, IKS requires you to put the label `ibm-cloud.kubernetes.io/node-local-dns-enabled:true` on worker pools. In terraform, the [resource_ibm_container_vpc_worker_pool](https://github.com/IBM-Cloud/terraform-provider-ibm/blob/8190c309169c4204b65b3611f7270ee81348c13c/ibm/resource_ibm_container_vpc_worker_pool.go#L459) calls IgnoreSystemLabels which excludes anything with `ibm-cloud` prefix. I understand the general requirement to ignore IBM Lables that IKS appends, but this prefix should not be skipped.
@hkantare hkantare merged commit a9d387e into IBM-Cloud:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants