Do not ignore label to enable node-local-dns-enabled for kubernetes service #3232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable node local dns caching, IKS requires you to put the label
ibm-cloud.kubernetes.io/node-local-dns-enabled:true
on worker pools. In terraform, the resource_ibm_container_vpc_worker_pool calls IgnoreSystemLabels which excludes anything withibm-cloud
prefix. I understand the general requirement to ignore IBM labels that IKS appends, but this prefix should not be skipped.Right now, every time I run
terraform plan
it shows that it will add this label, even though it already exists.Community Note
Relates OR Closes #0000
Output from acceptance testing: