-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement the changes to enable/update the BFD config for the DirectLink gateways #3194
Conversation
…irectlink gateways * allow the user to add bfd_interval and bfd_multiplier for BFD configuration * show the status, interval, multiplier and bfd status updated at for Directlink Gateways
}, | ||
dlBfdStatusUpdatedAt: { | ||
Type: schema.TypeString, | ||
Computed: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can bfd_status_updated_at this be optional field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BFD status updated at has been created as an optional field for ibm_dl_gateway resource at L123
}, | ||
dlBfdStatus: { | ||
Type: schema.TypeString, | ||
Computed: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status can be a optional field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BFD status has been created as an optional field for ibm_dl_gateway resource at L117
@@ -59,6 +59,8 @@ resource "ibm_dl_gateway" "test_dl_connect" { | |||
Review the argument reference that you can specify for your resource. | |||
|
|||
- `authentication_key` - (Optional, String) BGP MD5 authentication key. | |||
- `bfd_interval` - (String) Minimum interval in milliseconds at which the local routing device transmits hello packets and then expects to receive a reply from a neighbor with which it has established a BFD session. | |||
- `bfd_multiplier` - (String) The number of hello packets not received by a neighbor that causes the originating interface to be declared down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other two attributes bfd_status_updated_at and status one need to be added to attribute section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added to attribute section here
Community Note
Implement the following changes for Direct Link Gateways:
bfd_interval
andbfd_multiplier
for BFD configurationstatus
,interval
,multiplier
andbfd status
updated at for DirectLink GatewaysOutput from acceptance testing: