Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: lb https redirect #3115

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

deepaksibm
Copy link
Contributor

@deepaksibm deepaksibm commented Sep 16, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIBMISLBListener_basic'
=== RUN   TestAccIBMISLBListener_basic
--- PASS: TestAccIBMISLBListener_basic (912.70s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 917.068s
...

@kavya498
Copy link
Collaborator

Please attach testcase results

@hkantare
Copy link
Collaborator

Please add some testcases fro this new feature and sahre the results of all testcases of (listenere, policy)

@deepaksibm
Copy link
Contributor Author

$ make testacc TEST=./ibm TESTARGS='-run=TestAccIBMISLBListenerHttpRedirect_basic'
=== RUN   TestAccIBMISLBListenerHttpRedirect_basic
--- PASS: TestAccIBMISLBListenerHttpRedirect_basic (960.61s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 963.433s

@deepaksibm deepaksibm force-pushed the feature-is-lb-redirect-https branch from 425c5ad to 6d4cc4c Compare October 1, 2021 11:17
@deepaksibm deepaksibm force-pushed the feature-is-lb-redirect-https branch from 6d4cc4c to 70c0e26 Compare October 4, 2021 14:40
@deepaksibm
Copy link
Contributor Author

deepaksibm commented Oct 4, 2021

$ make testacc TEST=./ibm TESTARGS='-run=TestAccIBMISLBListenerPolicyHttpRedirect_basic'
=== RUN   TestAccIBMISLBListenerPolicyHttpRedirect_basic

--- PASS: TestAccIBMISLBListenerPolicyHttpRedirect_basic (1244.22s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 1247.092s

@hkantare hkantare merged commit 91a91f2 into IBM-Cloud:master Oct 18, 2021
@deepaksibm deepaksibm deleted the feature-is-lb-redirect-https branch October 19, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants