updated security group target APIs #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hkantare
reviewed
Jul 28, 2021
ibm/resource_ibm_is_security_group_network_interface_attachment.go
Outdated
Show resolved
Hide resolved
astha-jain
reviewed
Aug 6, 2021
website/docs/r/is_security_group_network_interface_attachment.html.markdown
Show resolved
Hide resolved
deepaksibm
force-pushed
the
bug-is-update-secgrp-netinterface-apis
branch
from
237f606
to
7cb5c3e
Compare
| @@ -344,7 +344,7 @@ func init() { | |||
| isImage = os.Getenv("IS_IMAGE") | |||
| if isImage == "" { | |||
| //isImage = "fc538f61-7dd6-4408-978c-c6b85b69fe76" // for classic infrastructure | |||
| isImage = "r006-5b05b4fe-bcbc-4309-ad45-3354813227a0" // for next gen infrastructure | |||
| isImage = "r134-9573cb89-984e-45a4-bfc5-df611bbb8e7d" // for next gen infrastructure | |||
| fmt.Println("[INFO] Set the environment variable IS_IMAGE for testing ibm_is_instance, ibm_is_floating_ip else it is set to default value 'r006-ed3f775f-ad7e-4e37-ae62-7199b4988b00'") | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This can be removed
|
@hkantare I have reviewed this PR, From my end this looks fine to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing: