Add Migratable to pi_instance #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkantare
reviewed
Jul 2, 2021
ibm/resource_ibm_pi_instance.go
Outdated
| @@ -300,6 +301,10 @@ func resourceIBMPIInstanceCreate(d *schema.ResourceData, meta interface{}) error | |||
| if r, ok := d.GetOk(helpers.PIInstanceReplicationScheme); ok { | |||
| replicationNamingScheme = r.(string) | |||
| } | |||
| var migartable bool | |||
| @@ -60,6 +60,7 @@ func resourceIBMPIInstance() *schema.Resource { | |||
| }, | |||
| "migratable": { | |||
| Type: schema.TypeBool, | |||
There was a problem hiding this comment.
I think as per desgin we added arguments starts with pi_...Should be add a new argument pi_migartable instead of migartable(may be we can mark this as derprecated)
kavya498
force-pushed
the
power
branch
2 times, most recently
from
97b96ff
to
63e0b63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #1154, #1701