Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit & KeyID Feature for Keys DataSource #2538

Merged
merged 8 commits into from
Jul 27, 2021
Merged

Limit & KeyID Feature for Keys DataSource #2538

merged 8 commits into from
Jul 27, 2021

Conversation

harshit777
Copy link
Contributor

Current Behavior
The KP Terraform data source doesn't have provision to search all keys in an instance for a given key-name as an input. Moreover, there is a limitation in KP SDK which limits the number of keys to 2000 when it is not overwritten. Due to this behaviour, there are chances that the user may not be able to retrieve the required key when searching based on the key name and hence this behaviour need to be updated with the following changes so that the user has the flexibility to include all the keys to search for the required key name and also able to search based on key_id & key_alias.

Expected Behavior

  • Optional param to send the limit and add pagination logic to search until the limit when it is passed in the input.
  • key_id or key_alias as optional input
  • Both datasource_ibm_kms_keys and datasource_ibm_kms_key to be updated with these changes
  • When the limit is not passed, the behaviour is as it is today.

website/docs/d/kms_key.html.markdown Show resolved Hide resolved
website/docs/d/kms_key.html.markdown Show resolved Hide resolved
website/docs/d/kms_key.html.markdown Outdated Show resolved Hide resolved
website/docs/d/kms_key.html.markdown Outdated Show resolved Hide resolved
website/docs/d/kms_keys.html.markdown Outdated Show resolved Hide resolved
@hkantare hkantare merged commit c340e33 into IBM-Cloud:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants