Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key rings #2378

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Key rings #2378

merged 1 commit into from
Mar 24, 2021

Conversation

harshit777
Copy link
Contributor

No description provided.

@kavya498
Copy link
Collaborator

Please Rebase the code
Looks like your PR has one old commit Fix: config.go and provider_test.go

hkantare
hkantare reviewed Mar 24, 2021
View reviewed changes
ibm/data_source_ibm_kms_key_rings.go Outdated Show resolved Hide resolved
ibm/data_source_ibm_kms_key_rings.go Outdated Show resolved Hide resolved
ibm/data_source_ibm_kms_key_rings.go Outdated Show resolved Hide resolved
ibm/data_source_ibm_kms_key_rings.go Show resolved Hide resolved
ibm/resource_ibm_kms_key.go Show resolved Hide resolved
ibm/resource_ibm_kms_key_rings.go Outdated Show resolved Hide resolved
ibm/resource_ibm_kms_key_rings.go Outdated Show resolved Hide resolved
website/docs/r/kms_key.html.markdown Outdated Show resolved Hide resolved
@hkantare
Copy link
Collaborator

Fix the conflict in go.sum

@hkantare hkantare merged commit f15abe9 into IBM-Cloud:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare left review comments

@kavya498 kavya498 kavya498 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshit777 @kavya498 @hkantare