DS: VPC Floating IP #1794
Merged
DS: VPC Floating IP #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkantare
reviewed
Aug 12, 2020
| floatingIPZone: { | ||
| Type: schema.TypeString, | ||
| Computed: true, | ||
| ConflictsWith: []string{isFloatingIPTarget}, |
There was a problem hiding this comment.
Remove ConflictsWith..its a computed field
| floatingIPTarget: { | ||
| Type: schema.TypeString, | ||
| Computed: true, | ||
| ConflictsWith: []string{isFloatingIPZone}, |
| return err | ||
| } | ||
|
|
||
| floatingIPOptions := &vpcclassicv1.ListFloatingIpsOptions{} |
There was a problem hiding this comment.
Use the option start parameter....which we added for other datasources for List
start
string
A server-supplied token determining what resource to start the page on
check other datasources
| return err | ||
| } | ||
|
|
||
| floatingIPOptions := &vpcv1.ListFloatingIpsOptions{} |
| } | ||
| } | ||
|
|
||
| return nil |
There was a problem hiding this comment.
If not name matches return fmt.Error("No floatingIP found with name....")
| } | ||
| } | ||
|
|
||
| return nil |
There was a problem hiding this comment.
If not name matches return fmt.Error("No floatingIP found with name....")
| } | ||
|
|
||
| ``` | ||
|
|
There was a problem hiding this comment.
Add Argument Reference section (required variables)
|
|
||
| The following attributes are exported: | ||
| * `id` - An alphanumeric value identifying the floating ip. | ||
| * `name` - Name for the floating IP address. |
There was a problem hiding this comment.
Remove name from attribute reference section
| keys = [ibm_is_ssh_key.testacc_sshkey.id] | ||
| } | ||
|
|
||
| data "ibm_is_floating_ip" "test" { |
There was a problem hiding this comment.
Remove all other resources just keep data "ibm_is_floating_ip"
umarali-nagoor
force-pushed
the
vpc_floating_ip
branch
from
5b5cbda to
0371f94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Results: