Flatpak changes #42
Flatpak changes #42
Conversation
|
Instead of maintaining a massive list of what not to build I suggest just building the single plugin you want like so: https://github.com/flathub/io.github.Pithos/blob/0a149e953c59b9410b5282a01b0e0e23e9f230f1/io.github.Pithos.json#L32-L44 |
|
Also if its a 1.16.1 specific regression (which sounds odd), add a comment. |
|
Is there a way of checking what modules are currently being used? I guess otherwise it's going to be trial and error to see which one being replaced "fixes" things. |
|
Nm, it seems building just gst/mpegtsdemux/libgstmpegtsdemux.so is what was "fixing it". This makes no sense. |
|
Some videos of the glitch I've been experiencing. with old mpegtsdemux (1.16.0) - https://drive.google.com/open?id=1l1IA99HnChbwwJI-Yj9zzOzFoeJwe-1r in the latter, the video freezes at 4 seconds. |
|
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/commit/cd8bb641f81b7a7a0379aff9334b36a8eb9e638f is what is causing the problem |
|
Good job tracking it down 😃 Is this regression reported upstream? |
I couldn't find it upstream. I'll file it when I get a minute. In the mean time I've attached a patch to this MR that reverts the troubling commit. |
|
Is this good to merge now? |
This should be fine to merge into this repo, it doesn't conflict with anything. I've been busy the last couple of weeks and haven't got around to debugging the output to go onto a bug report upstream. |
|
Did someone report this against GStreamer in the end? I can't find any issue that looks related. |
|
I've been super busy with work the last few weeks and haven't had the chance to look into this, as much I would've liked (sorry). I'm not that clued on the GStreamer stack, but I see some changes upstream on GStreamer where this bug is, I'll today compile with the latest upstream changes and see if there's any difference. |
|
This seems fixed on the upstream gst-plugins-bad 1.16 branch. Edit: Was fixed by https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/commit/cfa0f1858075a3390def50250eafc89d270178d3, updated manifest coming up. |
|
Thanks for finding that! Hopefully the backport will be released (and packaged by distros) soon. |
Apparently it's meant to be done, there's no way to stop gettext picking it up, and not translating just messes up the completion percentages. My name is now pre-translated in all languages instead.
@TingPing Do these look good to you?
This removes the un-needed gst-plugins-ugly and disables a bunch of plugins that aren't used by Twitter for gst-plugins-bad, which reduces the disk usage by around 50%.