Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Linkify DMs #13

Closed
IBBoard opened this issue Sep 1, 2019 · 1 comment
Closed

Linkify DMs #13

IBBoard opened this issue Sep 1, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@IBBoard
Copy link
Owner

IBBoard commented Sep 1, 2019

Links and handles in DMs currently do not linkify. This may be a Twitter API/JSON limitation, but it seems odd to do that. We should linkify if possible.
@IBBoard IBBoard added the enhancement New feature or request label Sep 1, 2019
@IBBoard
Copy link
Owner Author

IBBoard commented Sep 14, 2019

This is a database issue. We store the plain text, but not the metadata for the link position. When the DM first comes in then it is linkified, but not when we reload it from the database.

We may need to save the markup in the database instead (and update old messages as we see them, if possible)

@valerierx valerierx mentioned this issue Oct 21, 2019
Closed
@schmittlauch schmittlauch mentioned this issue Jan 5, 2020
Closed
IBBoard added a commit that referenced this issue Aug 22, 2020
@IBBoard
Re #13: Linkify DMs by storing JSON
1785c11 
We previously just stored the flattened text. Now we are
can show linkified text and should be future-proofed!

Note: This will only fix recent tweets that the API still serves up.

Fixes #13. Should add some required underpinnings for #12.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IBBoard