This repository has been archived by the owner on Nov 17, 2022. It is now read-only.
218ify create_x_path() functions in resources.py
#263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for the completion of some things in #255
A fixture is removed following a mis-remembering of how 'version-independent' works.
hayfield
added
api
The name was longer than needed following previous iterations of the name
70 tasks
This includes: - decimal - integer - version-independent
This makes it clearer that the class works with creating paths, rather than XPaths (which are something completely different...)
There is one for Major versions, so there should also be one for Minor versions. Consistency.
This checks that values: - use a dot (.) as a decimal separator - have 2 decimal places - do not contain leading or trailing whitespace
This will detect if patch versioning is introduced
This brings it in line with #255
|
The |
|
This PR has been superceded by #297 (which has the advantage of having recent changes from |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the
create_x_path()checklist in #255Includes content from #264 (should probably merge that through to the relevant point first)