This repository has been archived by the owner on Nov 17, 2022. It is now read-only.
Rename version-specific resource folders #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #185 Up to this point folders for specific versions are named, eg. , and . By doing this, it is ambiguous where in the folder name the integer part ends and the decimal part begins. This will become even more of a problem should SemVer be used.As such, there should be a separator between the components of the Version Number. A hyphen is chosen since it is a clear separator and has no special meaning in either regular expressions (outside of [character classes](https://stackoverflow.com/questions/9589074/regex-should-hyphens-be-escaped), which is a non-issue) or in filepaths on any sane filesystem.
hayfield
added
complete
|
(yes, the Changelog has the correct PR number despite this only being a single commit - magic!) |
|
...failing test :D |
hayfield
added
incomplete
f5d35bc made some changes without updating a key test. This fixes the failing test
hayfield
added
complete
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #185
This removes the ambiguity in where the separation between components in version numbers lies. This would become even more of a problem should SemVer be used.
A hyphen is chosen since it is a clear separator and has no special meaning in either regular expressions (outside of character classes, which is a non-issue) or in filepaths on any sane filesystem.