Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

Commit

Permalink
Merge pull request #309 from IATI/remove-python-3.4-support
Browse files Browse the repository at this point in the history
Remove python 3.4 support
  • Loading branch information
hayfield authored Mar 22, 2018
2 parents 85330fc + f183b9e commit cad4440
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ cache:
pip
python:
- 2.7
- 3.4
- 3.5
- 3.6
install:
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a

- [Resources] Functions in the `resources` module no longer have default values for the `version` argument. [#297]

- [Compatibility] Drop support for Python 3.4. [#309]

### Fixed

- [Resources] Re-implement support for 2.03 from the ground up to improve correctness and reduce number of undetectable bugs. [#307]
Expand Down
4 changes: 2 additions & 2 deletions iati/resources.py
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ def path_for_version(path, version):
Does not check whether anything exists at the specified path.
"""
try: # python2 and python3.4 compatibility
try: # python2 compatibility
_ensure_portable_filepath(path)
except ValueError:
if path != '':
Expand Down Expand Up @@ -516,7 +516,7 @@ def _ensure_portable_filepath(maybe_filepath):
This restriction is currently tight since it's easier to tighten than loosen restrictions. The restriction could be relaxed over time.
Todo:
Consider utilising the Python3.4 concept of path-like objects.
Consider utilising the Python3 concept of path-like objects from the pathlib module.
"""
if not isinstance(maybe_filepath, str):
Expand Down
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
'Operating System :: OS Independent',
'Programming Language :: Python',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Topic :: Scientific/Engineering :: Information Analysis',
Expand Down

0 comments on commit cad4440

Please sign in to comment.