extend pseudo-regexp in pattern_match() for $
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a litte bit disappointed by stickler... |
gidden
reviewed
Sep 20, 2018
pyam/core.py
Outdated
| dictionary of filters ({col: values}}); uses a pseudo-regexp syntax by | ||
| default, but accepts `regexp: True` to use direct regexp | ||
| """ | ||
| regexp = filters.pop('regexp') if 'regexp' in filters else False |
There was a problem hiding this comment.
this can just be regexp = filters.pop('regexp', False)
|
lgtm, one suggestion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Description of PR
This PR adds the
$symbol to the list of characters escaped in thepattern_match()function, to allow filtering for e.g.unit='US$'.It also adds the option to functions using
_apply_filters()to passregexp=Trueas a kwarg, overriding the pseudo-regexp syntax inpattern_match(). Closes #79