Allow rename() for model and scenarios
#87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gidden
reviewed
Sep 17, 2018
tests/test_core.py
Outdated
| ], columns=['model', 'scenario', 'exclude'] | ||
| ).set_index(META_IDX) | ||
|
|
||
| print(obs.meta) |
|
lgtm, can you rebase/update on current |
danielhuppmann
force-pushed
the
rename_index
branch
from
c4023c9
to
804f155
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Description
This PR extends the
rename()function to also work for themodelandscenarionames. In contrast to renaming ofvariableorregion, renaming bymodelandscenarioenforces a uniquemeta.indexand will raise an error if renaming leads to duplicates of model-scenario combination.