add ability to read rcp db data #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mind taking a look @znicholls ? |
|
Looks good to me! |
|
feel free to squash and merge =) |
danielhuppmann
requested changes
Jul 16, 2018
pyam/utils.py
Outdated
| if 'notes' in df.columns: # this came from the database | ||
| logger().info('Ignoring notes column in dataframe') | ||
| df.drop(columns='notes', inplace=True) | ||
| col = df.columns[0] # first column has database notes |
There was a problem hiding this comment.
please rephrase to 'copyright notice' or similar, the word 'notes' is confusing with the previous line
|
done! |
danielhuppmann
approved these changes
Jul 17, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Adding to RELEASE_NOTES.md
Please add a single line in the release notes similar to the following: