Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to read rcp db data #70

Merged
merged 5 commits into from
Jul 17, 2018
Merged

Conversation

gidden
Copy link
Member

@gidden gidden commented Jul 9, 2018

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Description in RELEASE_NOTES.md Added

Adding to RELEASE_NOTES.md

Please add a single line in the release notes similar to the following:

- (#XX)[http://link-to-pr.com] Added feature which does something

@gidden
Copy link
Member Author

gidden commented Jul 10, 2018

mind taking a look @znicholls ?

@znicholls
Copy link
Collaborator

Looks good to me!

@gidden
Copy link
Member Author

gidden commented Jul 10, 2018

feel free to squash and merge =)

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment on a docstring

pyam/utils.py Outdated
if 'notes' in df.columns: # this came from the database
logger().info('Ignoring notes column in dataframe')
df.drop(columns='notes', inplace=True)
col = df.columns[0] # first column has database notes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rephrase to 'copyright notice' or similar, the word 'notes' is confusing with the previous line

@gidden
Copy link
Member Author

gidden commented Jul 16, 2018

done!

@danielhuppmann danielhuppmann merged commit bae49ad into IAMconsortium:master Jul 17, 2018
@gidden gidden deleted the rcp branch June 15, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants