bugfix for interpolate() - duplication of values
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @danielhuppmann, looks good to me. However, could you add a test that fails without this fix? Can you also add this to the release notes? |
|
Probably easiest to rebase on master to get the release notes, FYI. |
danielhuppmann
force-pushed
the
interpolate_no_duplicates
branch
from
d35444e
to
5c764fe
Compare
|
rebased, extended the test for the @gidden, should be good to go! |
|
thanks @danielhuppmann ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
interpolatefunction, where values are duplicated if they are already defined. The fix only interpolates (and adds to theIamDataFrame.dataonly years that are missing.