Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with latest matplotlib and py3.8 #380

Merged
merged 11 commits into from
Jun 10, 2020

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented May 24, 2020

Please confirm that this PR has done the following:

  • Tests Added (matplotlib test figures updated)
  • Documentation Added
  • Description in RELEASE_NOTES.md Added

Description of PR

This PR adds a minor fix to scatter() to ensure compatibility with latest matplotlib and Python 3.8. The PR also deactivates explicitly the matplotlib tests on travis rather than the deactivation-by-outdated-freetype, see #372. Note that most plotting tests fail on travis (different figure size) even though the expected figures were built on Mac with identical matplotlib, freetype, etc. versions.

closes #374
closes #281

@coveralls
Copy link

coveralls commented May 24, 2020

Coverage Status

Coverage increased (+4.8%) to 90.862% when pulling 110bd29 on danielhuppmann:devops/py38-ci into 0b1de58 on IAMconsortium:master.

@danielhuppmann danielhuppmann changed the title Add py3.8 to CI Add compatibility with latest matplotlib and py3.8 Jun 10, 2020
@danielhuppmann danielhuppmann marked this pull request as ready for review June 10, 2020 05:09
@gidden
Copy link
Member

gidden commented Jun 10, 2020

Looks great, thanks @danielhuppmann !!

@gidden gidden merged commit 8145740 into IAMconsortium:master Jun 10, 2020
@danielhuppmann danielhuppmann deleted the devops/py38-ci branch June 26, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.8 install scatter plotting tests fail for recent matplotlib version
3 participants