[WIP] allow passing list of variables to [check_]aggregate[_region]() functions
#306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Dec 19, 2019
3 tasks
gidden
approved these changes
Dec 22, 2019
There was a problem hiding this comment.
Looks great @danielhuppmann. Is it possible to add an example of multiple values aggregation in one of the tutorials? Or is that too much trouble?
I'll update the tutorial in a later PR (as promised to @znicholls already). Will see if it makes sense there. |
|
closing in favour of #312 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)
Please add a single line in the release notes similar to the following:
Description of PR
This PR allows to pass a list of variables (rather than only single variables) to any function of the aggregation tools.
The PR is directed into
IAMconsortium:feature/aggregate_weightsto highlight the differences of the aggregation-features to that prep-work - I'll rebase after a first round of review and merging of #305.