Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] allow passing list of variables to [check_]aggregate[_region]() functions #306

Conversation

danielhuppmann
Copy link
Member

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Description in RELEASE_NOTES.md Added

Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)

Please add a single line in the release notes similar to the following:

- (#XX)[http://link-to-pr.com] Added feature which does something

Description of PR

This PR allows to pass a list of variables (rather than only single variables) to any function of the aggregation tools.

The PR is directed into IAMconsortium:feature/aggregate_weights to highlight the differences of the aggregation-features to that prep-work - I'll rebase after a first round of review and merging of #305.

pyam/core.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/test_feature_aggregate.py Outdated Show resolved Hide resolved
Copy link
Member

@gidden gidden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @danielhuppmann. Is it possible to add an example of multiple values aggregation in one of the tutorials? Or is that too much trouble?

@danielhuppmann
Copy link
Member Author

Is it possible to add an example of multiple values aggregation in one of the tutorials? Or is that too much trouble?

I'll update the tutorial in a later PR (as promised to @znicholls already). Will see if it makes sense there.

@danielhuppmann
Copy link
Member Author

closing in favour of #312

@danielhuppmann danielhuppmann deleted the feature/aggregate_by_list branch December 23, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants