Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for writing to_excel with pd.ExcelWriter #301

Merged
merged 3 commits into from
Dec 7, 2019
Merged

Bugfix for writing to_excel with pd.ExcelWriter #301

merged 3 commits into from
Dec 7, 2019

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Dec 5, 2019 •
edited by byersiiasa
Loading

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Description in RELEASE_NOTES.md Added

Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)

Please add a single line in the release notes similar to the following:

- (#XX)[http://link-to-pr.com] Added feature which does something

Description of PR

Bugfix when using to_excel() with a pd.ExcelWriter instance, including an extension of the unit test.

Closes #300

@coveralls
Copy link

coveralls commented Dec 5, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 84.879% when pulling 84def56 on danielhuppmann:bugfix/excelwriter into f049113 on IAMconsortium:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 84.879% when pulling 1c5af8f on danielhuppmann:bugfix/excelwriter into f049113 on IAMconsortium:master.

@danielhuppmann
Copy link
Member Author

@byersiiasa, this should do the trick - please review!

byersiiasa
byersiiasa approved these changes Dec 7, 2019
View reviewed changes
Copy link
Collaborator

@byersiiasa byersiiasa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works - thanks a lot!

@byersiiasa byersiiasa merged commit 9931f38 into IAMconsortium:master Dec 7, 2019
@danielhuppmann danielhuppmann deleted the bugfix/excelwriter branch December 12, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byersiiasa byersiiasa byersiiasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to_excel close
3 participants
@danielhuppmann @coveralls @byersiiasa