Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging #288

Merged
merged 4 commits into from
Nov 12, 2019
Merged

Update logging #288

merged 4 commits into from
Nov 12, 2019

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Nov 10, 2019

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Description in RELEASE_NOTES.md Added

Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)

Please add a single line in the release notes similar to the following:

- (#XX)[http://link-to-pr.com] Added feature which does something

Description of PR

This PR updates pyam's logging so that it no longer clashes with the root logger and is properly namespaced. At the moment, pyam uses the root logger, which means you can't only turn Pyam's logging off rather you have to adjust all logging or none (see the new tests). With this change, pyam's loggers are put in their own namespace so they can be adjusted by libraries which use them without having to touch the root logger. The more detailed explanation of why this should be changed is explained here (this could also be a useful resource if we want to write something about this in the docs).

@znicholls znicholls changed the title [WIP] Update logging Update logging Nov 10, 2019
@znicholls znicholls marked this pull request as ready for review November 10, 2019 03:20
@znicholls
Copy link
Collaborator Author

@gidden does this need documentation?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 85.051% when pulling f03ce36 on znicholls:update-logging into a4e266c on IAMconsortium:master.

@gidden
Copy link
Member

gidden commented Nov 12, 2019

@znicholls not for the moment. if a future issue comes up, I'll be sure to assign you =)

@gidden
Copy link
Member

gidden commented Nov 12, 2019

this looks great @znicholls, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants