Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all region-plotting related features, docs, etc. #275

Merged
merged 5 commits into from
Oct 22, 2019

Conversation

gidden
Copy link
Member

@gidden gidden commented Oct 18, 2019

This completely removes all region-plotting related code. I will make an issue to reinstate it.

tests/test_plotting.py Outdated Show resolved Hide resolved
tests/test_plotting.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Oct 18, 2019

Coverage Status

Coverage increased (+2.6%) to 90.768% when pulling 96712ac on gidden:rm-region into 151bc67 on IAMconsortium:master.

@znicholls
Copy link
Collaborator

What's the motivation for removing map_regions, that works fine doesn't it?

@danielhuppmann
Copy link
Member

What's the motivation for removing map_regions, that works fine doesn't it?

See the related issue #225

@znicholls
Copy link
Collaborator

See the related issue #225

Ok but there's features in map_region that aren't in aggregate_region right? Particularly the inbuilt mappings? If this is a refactoring operation (which is my understanding of #225), wouldn't it make sense to leave map_regions in and ensure continuity of the tests during the refactoring? (I ask out of curiosity and to learn more about how to approach this sort of operation, I don't actually have any strong feelings.)

@gidden
Copy link
Member Author

gidden commented Oct 19, 2019

Ok all, thanks first to @znicholls - we can and should keep map_region in for the moment. It's added back with tests, this should be good to go now.

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gidden!

@danielhuppmann danielhuppmann merged commit 1627f56 into IAMconsortium:master Oct 22, 2019
@gidden gidden deleted the rm-region branch June 15, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants