Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack plot bug part 1 issue 266 #270

Merged

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Sep 30, 2019

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added (N/A)
  • Description in RELEASE_NOTES.md Added

Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)

Please add a single line in the release notes similar to the following:

- (#XX)[http://link-to-pr.com] Added feature which does something

Description of PR

Addresses the first problem identified in #266

tests/test_plotting.py Show resolved Hide resolved
tests/test_plotting.py Show resolved Hide resolved
@znicholls znicholls marked this pull request as ready for review September 30, 2019 11:42
@znicholls
Copy link
Collaborator Author

This fixes the first part of #266. The wrong image can be seen here with the correction available here. Do we want this added to the tutorial too or not worry about it as this is a bug fix?

@coveralls
Copy link

coveralls commented Sep 30, 2019

Coverage Status

Coverage decreased (-0.3%) to 87.873% when pulling f2260e4 on znicholls:stack-plot-bug-part-1-issue-266 into 1d0d5d2 on IAMconsortium:master.

@danielhuppmann
Copy link
Member

thanks @znicholls! I don't think that this needs to go into the tutorial, as it just fixes unexpected behaviour...

Can you rebase, then I'll merge?

@znicholls znicholls force-pushed the stack-plot-bug-part-1-issue-266 branch from f667f85 to 9e05b7c Compare October 17, 2019 04:53
@znicholls
Copy link
Collaborator Author

Can you rebase, then I'll merge?

cool done thanks @danielhuppmann !

@danielhuppmann
Copy link
Member

It seems that appveyor upgraded to a new version of matplotlib, causing this error. I think I solved a similar problem by downgrading.

@gidden, does it make sense to do that here as a quickfix, too, or is it worthwhile to make the underlying use of matplotlib-internals more robust?

@gidden
Copy link
Member

gidden commented Oct 18, 2019

Took a quick look at the logs, specifically conda list.

Last success:

...
markupsafe                1.1.1            py37he774522_0  
matplotlib                3.0.3            py37hc8f65d3_0  
mistune                   0.8.4            py37he774522_0  
...

This PR:

...
matplotlib                3.0.3            py37hc8f65d3_0  
matplotlib-base           3.1.1            py37h2852a4a_1    conda-forge
mistune                   0.8.4            py37he774522_0
...

Let me do a quick test in #274

@gidden
Copy link
Member

gidden commented Oct 18, 2019

ok, looks like #274 has a fix. mind incorporating it?

@znicholls znicholls force-pushed the stack-plot-bug-part-1-issue-266 branch from 9e05b7c to d5e5633 Compare October 19, 2019 00:11
@znicholls
Copy link
Collaborator Author

mind incorporating it?

yep done

@znicholls znicholls force-pushed the stack-plot-bug-part-1-issue-266 branch from d5e5633 to f2260e4 Compare October 19, 2019 02:40
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @znicholls!

@danielhuppmann danielhuppmann merged commit 151bc67 into IAMconsortium:master Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants