Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a validation check to rename() #202

Merged
merged 7 commits into from
Feb 27, 2019
Merged

Add a validation check to rename() #202

merged 7 commits into from
Feb 27, 2019

Commits on Feb 26, 2019

  1. add first try for rename(check_duplicates=True)

    @danielhuppmann
    danielhuppmann committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    a6a9243 View commit details
    Browse the repository at this point in the history

  2. add test for rename(check_duplicates=True)

    @danielhuppmann
    danielhuppmann committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    1e9d7cf View commit details
    Browse the repository at this point in the history

  3. extend error message to show conflict rows

    @danielhuppmann
    danielhuppmann committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    cf82db4 View commit details
    Browse the repository at this point in the history

  4. appease stickler

    @danielhuppmann
    danielhuppmann committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    86bd474 View commit details
    Browse the repository at this point in the history

  5. add to release notes

    @danielhuppmann
    danielhuppmann committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    cf89887 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2019

  1. only make interim copy if check_duplicates is True, add inline comment

    @danielhuppmann
    danielhuppmann committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    80bb251 View commit details
    Browse the repository at this point in the history

  2. pep8

    @danielhuppmann
    danielhuppmann committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    57115e7 View commit details
    Browse the repository at this point in the history