Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outside legends #201

Merged
merged 7 commits into from
Mar 29, 2019
Merged

Conversation

gidden
Copy link
Member

@gidden gidden commented Feb 26, 2019

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Description in RELEASE_NOTES.md Added

Add tutorial and native support for legends outside of plots

@gidden
Copy link
Member Author

gidden commented Feb 26, 2019

@znicholls @rossursino here is an example where I added a new figure test

@znicholls
Copy link
Collaborator

here is an example where I added a new figure test

thank you!

@coveralls
Copy link

coveralls commented Feb 26, 2019

Coverage Status

Coverage increased (+0.04%) to 84.725% when pulling 9f30ee5 on gidden:outside-legends into 381c4f6 on IAMconsortium:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 84.516% when pulling dfbfc26 on gidden:outside-legends into fcb81fe on IAMconsortium:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 84.516% when pulling dfbfc26 on gidden:outside-legends into fcb81fe on IAMconsortium:master.

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @gidden for this improvement!

I'm wondering if there may be a more user-friendly way to use this feature than
line_plot(legend=plotting.OUTSIDE_LEGEND['right'])...?

Maybe line_plot(legend='outside right') following the example of https://matplotlib.org/api/pyplot_api.html#matplotlib.pyplot.legend?

@gidden
Copy link
Member Author

gidden commented Feb 28, 2019 via email

@danielhuppmann danielhuppmann merged commit cb3af7e into IAMconsortium:master Mar 29, 2019
@gidden gidden deleted the outside-legends branch June 15, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants