updating for versioneer

[gidden]

Please confirm that this PR has done the following:

• Tests Added
• Documentation Added
• Description in RELEASE_NOTES.md Added

Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)

Please add a single line in the release notes similar to the following:

- (#XX)[http://link-to-pr.com] Added feature which does something

Description of PR

This PR uses versioneer to automatically generate appropriate version numbers. If on a tag, it will provide the current tag as the version (for packaging). If on a certain commit, it will name the commit like so:

$ python -c 'import pyam; print(pyam.__version__)'
0.1.2+6.g04b4940

[znicholls]

The install stuff isn't vital so merge if you want. If you want to make sure everything is behaving, I'd double check this RunTests class business.

[znicholls]

Is this class redundant now that you're using "cmdclass": versioneer.get_cmdclass(), below? Looking at https://stormpath.com/blog/building-simple-cli-interfaces-in-python again, I think it needs to be setup something like https://github.com/znicholls/netcdf-scm/blob/master/setup.py for this to actually do anything.

[gidden]

Yes, it is. I wasn't sure what exactly to do with it, since I didn't add it (I believe you did, right?).

In any case, I can mirror your netcdf-scm style or we can just remove it. I always run pytest tests and not python setup.py test. Do you have a preference?

[znicholls]

Pep440, toss a coin Command class, I think copy netcdfscm. I think you have to have the command class in there and this seems to be the way to make it work..

…

On Thu, 29 Nov 2018 at 5:09 pm, Matthew Gidden ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In setup.py <#145 (comment)>: > - - def finalize_options(self): - install.finalize_options(self) - - def run(self): - install.run(self) - dirs = [ - 'pyam.egg-info', - 'build', - ] - for d in dirs: - if os.path.exists(d): - print('removing {}'.format(d)) - shutil.rmtree(d) - - # thank you https://stormpath.com/blog/building-simple-cli-interfaces-in-python class RunTests(Command): """Run all tests.""" Yes, it is. I wasn't sure what exactly to do with it, since I didn't add it (I believe you did, right?). In any case, I can mirror your netcdf-scm style or we can just remove it. I always run pytest tests and not python setup.py test. Do you have a preference? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#145 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AWh-m-gXQoh9cQZZPr9jlkNHlnH3aDxsks5uz6RUgaJpZM4Y1gPT> .

[gidden]

ok should be g2g @znicholls

[znicholls]

lgtm