fix 698 usermanual & translation fix 01 #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityadeshlahre
changed the title
mozzy11
reviewed
Feb 1, 2024
| @@ -10592,7 +10592,7 @@ COPY clinlims.menu (id, parent_id, presentation_order, element_id, action_url, c | |||
| 171 2 10 menu_sample_print_barcode /PrintBarcode.do \N banner.menu.printBarcode banner.menu.printBarcode f t | |||
| 89 62 40 menu_reports_export \N \N reports.export.byDate tooltip.reports.export.byDate f t | |||
| 174 2 5 menu_sample_eorder /ElectronicOrders.do \N banner.menu.eorders tooltip.bannner.menu.eorders f t | |||
| 175 38 1 menu_help_user_manual /documentation/UserManual \N banner.menu.help.usermanual tooltip.bannner.menu.help.usermanual t t | |||
| 175 38 1 menu_help_user_manual /documentation/OEGlobal_UserManual_en.pdf \N banner.menu.help.usermanual tooltip.bannner.menu.help.usermanual t t | |||
There was a problem hiding this comment.
You dont need to change the init SQL directly . you can do this via liquibase
mozzy11
reviewed
Feb 1, 2024
| @@ -13,7 +13,7 @@ | |||
| <sqlCheck expectedResult="0">SELECT count(*) FROM clinlims.menu WHERE element_id = 'menu_help_user_manual' AND action_url = '/docs/UserManual'</sqlCheck> | |||
| </preConditions> | |||
| <update schemaName="clinlims" tableName="menu"> | |||
| <column name="action_url" value="/docs/UserManual" /> | |||
| <column name="action_url" value="/documentation/OEGlobal_UserManual_en.pdf" /> | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Thanks @adityadeshlahre for working on this. |
|
Thanks @adityadeshlahre . I made a quick fix in the controller |
|
@adityadeshlahre , get rid of the liquibase changes and i just merge the translation fixes |
adityadeshlahre
force-pushed
the
fix-698-breaking-user-manual
branch
from
3b53257
to
5f75219
Compare
|
hey @mozzy11 did the changes request . Thank You 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #698
User Manual is getting rendered on click.
fr language fixed
If any changes required let me know 😄
Thank You !