Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Lab Number Management E2E #1407

Merged
merged 17 commits into from
Jan 17, 2025
Merged

Conversation

Bahati308
Copy link
Contributor

@Bahati308 Bahati308 commented Jan 15, 2025

Added Lab Number Management E2E

Summary

Added the Lab Number Management E2E for the Admin

Screenshots

Screenshot from 2025-01-16 04-12-41

@mozzy11
Copy link
Collaborator

mozzy11 commented Jan 16, 2025

Thanks @Bahati308 , i can see the new added labNumberManagement E2E test fails in CI

@Bahati308
Copy link
Contributor Author

Thanks @Bahati308 , i can see the new added labNumberManagement E2E test fails in CI

Thanks @mozzy11 , all have been resolved.

mozzy11
mozzy11 previously approved these changes Jan 17, 2025
@mozzy11
Copy link
Collaborator

mozzy11 commented Jan 17, 2025

Hello @Bahati308 , i can see you have some build failre

@mozzy11
Copy link
Collaborator

mozzy11 commented Jan 17, 2025

@Bahati308 is this PR https://github.com/I-TECH-UW/OpenELIS-Global-2/pull/1398/files related to this ??
Can you just combine them ??

@Bahati308
Copy link
Contributor Author

Bahati308 commented Jan 17, 2025

@Bahati308 is this PR https://github.com/I-TECH-UW/OpenELIS-Global-2/pull/1398/files related to this ?? Can you just combine them ??

well, we could combine it, but I thought since we can have a test for home page, we could as well have one for navigation to the admin page. Otherwise it would not be logical for someone to access the admin pages component without verifying if the admin page loads successfully. How do you suggest

@Bahati308
Copy link
Contributor Author

Bahati308 commented Jan 17, 2025

Hello @Bahati308 , i can see you have some build failre

actually I realized something, it was some other test failing, mine had passed. It got me thinking if we could modify our QA framework workflows, is it necessary to re-run all tests even when a change is on one specific file ? This may work for now but as we get more and more tests, the checks will take hours to finish

@mozzy11 mozzy11 merged commit 1ca3111 into I-TECH-UW:develop Jan 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants