labs filter on csv routine report #1388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @pascagihozo , you can |
Bahati308
approved these changes
Jan 11, 2025
frontend/package.json
Outdated
There was a problem hiding this comment.
why was the prettier version changed ??
There was a problem hiding this comment.
It might be because I installed a new version on my pc hence the version changes
mozzy11
reviewed
Jan 13, 2025
| break; | ||
| default: | ||
| break; | ||
| if (props.report === "CISampleRoutineExport") { |
There was a problem hiding this comment.
why not just put this under the existing swtich statement
mozzy11
reviewed
Jan 13, 2025
| /> | ||
| {list.map((statusOption) => ( | ||
|
|
||
| {props.report === "CISampleRoutineExport" && |
There was a problem hiding this comment.
i think this is duplication code for the of dropdown
mozzy11
reviewed
Jan 13, 2025
| protected String selectedLabUnit; | ||
|
|
||
| // Add getter/setter | ||
| public void setLabUnit(String labUnit) { |
There was a problem hiding this comment.
This is a wrong getter name
mozzy11
reviewed
Jan 13, 2025
| this.selectedLabUnit = labUnit; | ||
| } | ||
|
|
||
| public String getLabUnit() { |
|
reworked on this here #1405 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requests Requirements
Issue number if applicable.
documentation.
Summary
This PR contains a drop down to allow the user to download CSV Routine report for a specific lab
Screenshots
Screencast.from.2025-01-10.10-43-14.webm
https://streamable.com/br9k6w
[Add relevant screenshots here if applicable]
Related Issue
[Add a link to the related issue or mention it here if applicable]
Other
[Add any additional information or notes here]