negative value for age input #1375 #1379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it is true that there are 12 months but logically it doesn't make any
sense, if someone have completed 12 months it directly means 1 whole year.
so age will increment by one whole year
…On Wed, Jan 8, 2025 at 11:38 PM LEMERI FESTUS ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In frontend/src/components/patient/CreatePatientForm.js
<#1379 (comment)>
:
> id="months"
+ min="0" // Prevent negative months
+ max="11" // Limit months to 0–11
+ onChange={(e) => {
+ let value = parseInt(e.target.value || 0);
+ value = Math.min(11, Math.max(0, value)); // value between 0 and 11
set this to 12 since there are 12 months
—
Reply to this email directly, view it on GitHub
<#1379 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDRUJK5J2W6YZG24JNSOUQT2JVSQVAVCNFSM6AAAAABU2N4MUGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMZXHA2DONRQGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hey Lemeri,
Do we have an update on this?
…On Wed, Jan 8, 2025 at 11:47 PM Yash Goyal ***@***.***> wrote:
it is true that there are 12 months but logically it doesn't make any
sense, if someone have completed 12 months it directly means 1 whole year.
so age will increment by one whole year
On Wed, Jan 8, 2025 at 11:38 PM LEMERI FESTUS ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In frontend/src/components/patient/CreatePatientForm.js
> <#1379 (comment)>
> :
>
> > id="months"
> + min="0" // Prevent negative months
> + max="11" // Limit months to 0–11
> + onChange={(e) => {
> + let value = parseInt(e.target.value || 0);
> + value = Math.min(11, Math.max(0, value)); // value between 0 and 11
>
> set this to 12 since there are 12 months
>
> —
> Reply to this email directly, view it on GitHub
> <#1379 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BDRUJK5J2W6YZG24JNSOUQT2JVSQVAVCNFSM6AAAAABU2N4MUGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMZXHA2DONRQGE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
mozzy11
reviewed
Jan 9, 2025
| placeholder={intl.formatMessage({ | ||
| id: "patient.information.days", | ||
| })} | ||
| /> | ||
| <div className="error"> | ||
| <ErrorMessage name="birthDateForDisplay"></ErrorMessage> |
There was a problem hiding this comment.
did you remove this error message intentionally ??
mozzy11
reviewed
Jan 9, 2025
| id="days" | ||
| min="0" // Prevent negative days | ||
| max="30" // Limit days to 0–30 |
There was a problem hiding this comment.
i think you cant hard code 30 as the max days as this varies depensidn on the month
There was a problem hiding this comment.
okay will change it to 31 or can make changes to code on month conditions also
mozzy11
reviewed
Jan 9, 2025
| max="11" // Limit months to 0–11 | ||
| onChange={(e) => { | ||
| let value = parseInt(e.target.value || 0); | ||
| value = Math.min(11, Math.max(0, value)); // value between 0 and 11 |
There was a problem hiding this comment.
This Logic is already handles
There was a problem hiding this comment.
which line, can you please explain a bit?
|
👋 Hi, @yashgoyal0110, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
|
@mozzy11 do we have some update? |
|
Thanks @yashgoyal0110 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1375
Issue number if applicable.
documentation.
Summary
Screenshots
[Add relevant screenshots here if applicable]
Related Issue
[Add a link to the related issue or mention it here if applicable]
Other
[Add any additional information or notes here]