-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feature) Query the Client Registry to retrieve patient data and import it into OpenELIS #1219
Conversation
b39e027
to
bb27300
Compare
src/main/java/org/openelisglobal/common/rest/provider/PatientSearchRestController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openelisglobal/common/rest/provider/PatientSearchRestController.java
Outdated
Show resolved
Hide resolved
👋 Hi, @mherman22, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
@mherman22 any more prpgress on this ?? |
I am working on updating this PR before end of day tomorrow. I have changes that query the client registry and return the patient to openelis, i am just debugging something to do with opencr and i created this PR to fix it at intrahealth/client-registry#148 |
Thanks @mherman22 |
when a client registry search is enabledwhen the CR search is not enabled and there is only a local searchcc: @mozzy11 |
Screencast.from.2024-08-31.23-14-14.webmcc: @mozzy11 |
src/main/java/org/openelisglobal/common/rest/provider/PatientSearchRestController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openelisglobal/common/rest/provider/PatientSearchRestController.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mherman22 for the great work .
i added a few minor comments.
But in general , the current Bussines Logic assumes the patient already exists in the Local DB before before it is searched from the Cleint Registry. That should be the case.
When searching the CR , the Logic should assume the patient already exists.
We should search directly the CR with the params , and if the returned FHIR patient results as a similar national ID or Patient ID as any local patient ,then its is removed from the CR results , otherwise we should have a button to import the CR result in the UI
src/main/java/org/openelisglobal/common/rest/provider/PatientSearchRestController.java
Show resolved
Hide resolved
Thanks @mherman22 .Generally Looks good |
src/main/java/org/openelisglobal/common/rest/provider/PatientSearchRestController.java
Show resolved
Hide resolved
src/main/resources/liquibase/2.8.x.x/client_registry_search_configurable.xml
Outdated
Show resolved
Hide resolved
src/main/resources/liquibase/2.8.x.x/client_registry_search_configurable.xml
Outdated
Show resolved
Hide resolved
src/main/resources/liquibase/2.8.x.x/client_registry_search_configurable.xml
Outdated
Show resolved
Hide resolved
src/main/java/org/openelisglobal/common/util/ConfigurationProperties.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openelisglobal/common/util/DefaultConfigurationProperties.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openelisglobal/common/rest/DisplayListController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openelisglobal/common/rest/provider/PatientSearchRestController.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mherman22 .
Generally Looks good. just update the property name to make it more meaningful
Thanks @mherman22 . Looks good |
Pull Requests Requirements
Issue number if applicable.
documentation.
Summary
Screenshots
[Add relevant screenshots here if applicable]
Related Issue
[Add a link to the related issue or mention it here if applicable]
Other
[Add any additional information or notes here]